feat: Add algorithm and tests for Project Euler Problem 29 (Distinct Powers)#1776
Open
zeal-2004 wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
feat: Add algorithm and tests for Project Euler Problem 29 (Distinct Powers)#1776zeal-2004 wants to merge 1 commit intoTheAlgorithms:masterfrom
zeal-2004 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
+ Coverage 85.87% 85.88% +0.01%
==========================================
Files 377 378 +1
Lines 19720 19737 +17
Branches 3005 3010 +5
==========================================
+ Hits 16935 16952 +17
Misses 2785 2785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pertrai1
reviewed
Sep 3, 2025
| it('should throw error when number is negative', () => { | ||
| expect(() => distinctPowers(-3)).toThrowError('Power out of scope') | ||
| }) | ||
| test('if the number is greater than or equal to 2', () => { |
Contributor
There was a problem hiding this comment.
Why not use it rather than test?
Author
There was a problem hiding this comment.
I'm sorry, I don't understand your question. Could you be more specific?
Contributor
There was a problem hiding this comment.
I see a couple usages of it(...) and now a couple using test(...). So I wondered why the different usage?
Author
There was a problem hiding this comment.
I referred to other test files for different questions while writing this code and they had this format. I have followed the same as per the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR for adding the algorithm and tests for Project-Euler Problem 29.
Vitest has been successfully carried passing all test cases.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.